Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tf/pt): add/refact lammps support for spin model #4216
feat(tf/pt): add/refact lammps support for spin model #4216
Changes from all commits
f34cbe1
d5b544b
dd331fd
31bafb1
15150f6
bdfe205
be59313
ec7c16b
6524e5e
2c66443
4f3d9d4
d24d7e7
593bf81
3466e34
c3a4f3e
e2e1e55
cf85275
1d6defe
2a38025
e5c0ecf
85c934b
35fd1c6
11aeb17
6c5cb1d
474a2b0
114898f
fef13f5
d4c7d1a
3afc2fd
9e82b8d
5a9a0a0
605fb9b
2cc6d8a
a0b7996
3dc6fff
36aee8d
c3bf841
5451acd
319493a
b1e4a03
de6abef
799b4e5
643e202
fb4dfe0
d1fd284
99e1e05
ae98964
3e7501e
2c4ca0d
7eab6cc
0965a70
af09efd
a532c33
919654e
c30091b
10b163e
811a0b9
0039aa4
ab15e47
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Documentation exists but could be more accessible in the freeze module
The nodes are well documented in other parts of the codebase:
virtual_len
: Distance between virtual atom and its corresponding real atom for each type of magnetic atomsspin_norm
: Magnitude of the magnetic moment for each type of magnetic atomsThese nodes are essential for the spin model functionality and are used in LAMMPS integration as documented in
doc/third-party/lammps-command.md
.Consider:
deepmd/tf/entrypoints/freeze.py
explaining these spin-related nodesdoc/model/train-energy-spin.md
) where these parameters are explained in detail🔗 Analysis chain
Consider adding documentation for spin-related nodes.
While the implementation is correct, it would be beneficial to:
Let's check if there's any existing documentation about these nodes:
Also applies to: 263-264
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 366
Script:
Length of output: 22572