Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: test Python 3.12 #4059

Merged
merged 3 commits into from
Aug 20, 2024
Merged

ci: test Python 3.12 #4059

merged 3 commits into from
Aug 20, 2024

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Aug 18, 2024 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores

    • Updated the Python version in the CI/CD workflow from 3.11 to 3.12, enhancing compatibility and performance for testing environments.

  • Bug Fixes

    • Improved error reporting in parallel training tests, providing clearer output for failures to aid in debugging.

@njzjz
ci: test Python 3.12
3c656d4 
Signed-off-by: Jinzhe Zeng <[email protected]>
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 18, 2024 •
edited
Loading

Walkthrough

Walkthrough

The primary change involves updating the Python version in the GitHub Actions workflow from 3.11 to 3.12, enhancing compatibility with the latest features and optimizations. Additionally, the error reporting in the parallel training test has been improved to provide clearer feedback during failures. These updates collectively enhance the testing environment and debugging capabilities in the continuous integration pipeline.

Changes

Files Change Summary
.github/workflows/test_python.yml Updated Python version from 3.11 to 3.12 in the CI workflow configuration.
source/tests/tf/test_parallel_training.py Improved error reporting in test_two_workers function for clearer diagnostics.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov Codecov
Copy link

codecov bot commented Aug 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.96%. Comparing base (05323f3) to head (b23a9aa).
Report is 174 commits behind head on devel.

Additional details and impacted files 
@@            Coverage Diff             @@
##            devel    #4059      +/-   ##
==========================================
+ Coverage   82.95%   82.96%   +0.01%     
==========================================
  Files         522      522              
  Lines       51044    51044              
  Branches     3028     3028              
==========================================
+ Hits        42342    42348       +6     
+ Misses       7756     7751       -5     
+ Partials      946      945       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz
Copy link
Member Author

njzjz commented Aug 18, 2024

=================================== FAILURES ===================================
2024-08-18T00:46:09.5071637Z ______________________ TestSingleMachine.test_two_workers ______________________
2024-08-18T00:46:09.5072344Z
2024-08-18T00:46:09.5072958Z self = <tests.tf.test_parallel_training.TestSingleMachine testMethod=test_two_workers>
2024-08-18T00:46:09.5073750Z
2024-08-18T00:46:09.5074112Z def test_two_workers(self):
2024-08-18T00:46:09.5075550Z command = "horovodrun -np 2 dp train -m workers " + self.input_file
2024-08-18T00:46:09.5076482Z penv = os.environ.copy()
2024-08-18T00:46:09.5077230Z num_gpus = len(get_gpus() or [])
2024-08-18T00:46:09.5077843Z if num_gpus > 1:
2024-08-18T00:46:09.5078472Z penv["CUDA_VISIBLE_DEVICES"] = "0,1"
2024-08-18T00:46:09.5079290Z elif num_gpus == 1:
2024-08-18T00:46:09.5079837Z raise unittest.SkipTest(
2024-08-18T00:46:09.5080841Z "At least 2 GPU cards are needed for parallel-training tests."
2024-08-18T00:46:09.5081763Z )
2024-08-18T00:46:09.5082229Z popen = sp.Popen(
2024-08-18T00:46:09.5082796Z command,
2024-08-18T00:46:09.5083378Z shell=True,
2024-08-18T00:46:09.5083895Z cwd=str(tests_path),
2024-08-18T00:46:09.5084491Z env=penv,
2024-08-18T00:46:09.5085086Z stdout=sp.PIPE,
2024-08-18T00:46:09.5085620Z stderr=sp.STDOUT,
2024-08-18T00:46:09.5086166Z )
2024-08-18T00:46:09.5086831Z for line in iter(popen.stdout.readline, b""):
2024-08-18T00:46:09.5087566Z if hasattr(line, "decode"):
2024-08-18T00:46:09.5088333Z line = line.decode("utf-8")
2024-08-18T00:46:09.5089090Z line = line.rstrip()
2024-08-18T00:46:09.5089662Z popen.wait()
2024-08-18T00:46:09.5090425Z > self.assertEqual(0, popen.returncode, "Parallel training failed!")
2024-08-18T00:46:09.5091531Z E AssertionError: 0 != 1 : Parallel training failed!
2024-08-18T00:46:09.5092069Z
2024-08-18T00:46:09.5092440Z source/tests/tf/test_parallel_training.py:48: AssertionError
2024-08-18T00:46:09.5093371Z

@njzjz njzjz marked this pull request as draft August 18, 2024 02:27
@njzjz njzjz marked this pull request as ready for review August 19, 2024 23:25
@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Aug 20, 2024
Merged via the queue into deepmodeling:devel with commit e47ca24 Aug 20, 2024
61 checks passed
mtaillefumier pushed a commit to mtaillefumier/deepmd-kit that referenced this pull request Sep 18, 2024
@njzjz @pre-commit-ci
ci: test Python 3.12 (deepmodeling#4059)
4861a84 
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **Chores**
- Updated the Python version in the CI/CD workflow from 3.11 to 3.12,
enhancing compatibility and performance for testing environments.
  
- **Bug Fixes**
- Improved error reporting in parallel training tests, providing clearer
output for failures to aid in debugging.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Jinzhe Zeng <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanghan-iapcm wanghan-iapcm wanghan-iapcm approved these changes

Assignees
No one assigned
Labels
Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@njzjz @wanghan-iapcm