Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Disallow improper capitalization #3982

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Jul 15, 2024

disallow DeepMD (excluding PairDeepMD), DeepMd, Pytorch, Tensorflow, Numpy, Github, Lammps, I-Pi, I-PI, i-Pi

Summary by CodeRabbit

  • Documentation

    • Standardized spelling of "LAMMPS," "NumPy," "PyTorch," and "GitHub" across all documents for consistency.
    • Updated references from "DeepMD" to "DeePMD-kit" in various installation and usage documentation.
    • Corrected capitalization of "i-PI" for clarity and uniformity in documentation.
  • Chores

    • Added a pre-commit hook to enforce proper capitalization of specified terms.
    • Typo corrections and minor updates in documentation and comments for improved clarity.

Copy link
Contributor

coderabbitai bot commented Jul 15, 2024

Walkthrough

Walkthrough

The updates address numerous minor typographical and consistency issues across various files, focusing on standardizing the capitalization of terms like "LAMMPS," "NumPy," "TensorFlow," and "DeePMD-kit." These changes enhance readability and maintain uniformity in documentation and code comments. Additionally, a new pre-commit hook was introduced to enforce proper capitalization of specific terms.

Changes

Files Change Summary
.github/labeler.yml, codecov.yml, ..., ... Corrected the capitalization of i-Pi to i-PI in various configuration and documentation files.
.pre-commit-config.yaml Added a new local hook disallow-caps to disallow improper capitalization in specified terms.
README.md, doc/.../quick_start.ipynb, ..., ... Changed Lammps to LAMMPS for consistency.
deepmd/utils/argcheck.py, source/cmake/Findtensorflow.cmake Corrected capitalization: Tensorflow to TensorFlow.
doc/data/data-conv.md, source/install/build_tf.py, ..., ... Updated references from Numpy to NumPy.
source/gmx/dp_gmx_patch, source/gmx/patches/... Changed DeepMD to DeePMD-kit in scripts and CMakeLists comments/messages.

Sequence Diagrams

No sequence diagrams are generated as the changes are too simple and varied, encompassing typographical corrections and standardizations rather than modifications to control flow or new features.


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5d3408c and e2fa8af.

Files selected for processing (1)
  • source/gmx/patches/2020.2/CMakeLists.txt.patch.in (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • source/gmx/patches/2020.2/CMakeLists.txt.patch.in

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

disallow DeepMD (excluding PairDeepMD), DeepMd, Pytorch, Tensorflow, Numpy, Github, Lammps, I-Pi, I-PI, i-Pi

Signed-off-by: Jinzhe Zeng <[email protected]>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Outside diff range, codebase verification and nitpick comments (4)
.pre-commit-config.yaml (1)

145-145: Clarification needed for the PairDeepMD exclusion.

The comment regarding the exclusion of PairDeepMD is unclear. It would be beneficial to provide more context or rationale for this decision.

doc/third-party/gromacs.md (2)

122-122: Grammar correction suggested.

Consider changing "default true" to "default is true" for better readability and grammatical correctness.

- - `pbc`: Optional, default true. If true, the GROMACS periodic condition is passed to DeePMD-kit.
+ - `pbc`: Optional, default is true. If true, the GROMACS periodic condition is passed to DeePMD-kit.
Tools
LanguageTool

[uncategorized] ~122-~122: Loose punctuation mark.
Context: ...Used in alchemical calculations. - pbc: Optional, default true. If true, the GR...

(UNLIKELY_OPENING_PUNCTUATION)


139-139: Grammar correction suggested.

The phrase "provides an evidence" should be corrected to "provides evidence".

- ...which further provides an evidence on the validity of our simulation.
+ ...which further provides evidence on the validity of our simulation.
Tools
LanguageTool

[grammar] ~139-~139: ‘an’ may be redundant when used with the uncountable noun ‘evidence’.
Context: ... with LAMMPS+DP, which further provides an evidence on the validity of our simulation. ![rd...

(A_UNCOUNTABLE_NOUN)

doc/train/multi-task-training-pt.md (1)

19-19: Spelling correction suggested.

The compound word "multi-task" should be hyphenated consistently throughout the document.

- In the PyTorch implementation, during the multi-task training process, all tasks can share any portion of the model parameters.
+ In the PyTorch implementation, during the multi-task training process, all tasks can share any portion of the model parameters.
Tools
LanguageTool

[misspelling] ~19-~19: This word is normally spelled as one.
Context: ... the PyTorch implementation, during the multi-task training process, all tasks can share a...

(EN_COMPOUNDS_MULTI_TASK)

source/gmx/patches/2020.2/CMakeLists.txt.patch.in Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.83%. Comparing base (399646e) to head (e2fa8af).
Report is 105 commits behind head on devel.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3982      +/-   ##
==========================================
- Coverage   82.83%   82.83%   -0.01%     
==========================================
  Files         522      522              
  Lines       50872    50872              
  Branches     3015     3015              
==========================================
- Hits        42142    42139       -3     
  Misses       7795     7795              
- Partials      935      938       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Jul 16, 2024
Merged via the queue into deepmodeling:devel with commit fc089c1 Jul 16, 2024
59 of 60 checks passed
mtaillefumier pushed a commit to mtaillefumier/deepmd-kit that referenced this pull request Sep 18, 2024
disallow DeepMD (excluding PairDeepMD), DeepMd, Pytorch, Tensorflow,
Numpy, Github, Lammps, I-Pi, I-PI, i-Pi

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Documentation**
- Standardized spelling of "LAMMPS," "NumPy," "PyTorch," and "GitHub"
across all documents for consistency.
- Updated references from "DeepMD" to "DeePMD-kit" in various
installation and usage documentation.
- Corrected capitalization of "i-PI" for clarity and uniformity in
documentation.

- **Chores**
- Added a pre-commit hook to enforce proper capitalization of specified
terms.
- Typo corrections and minor updates in documentation and comments for
improved clarity.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Jinzhe Zeng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants