-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pt/tf/dp): normalize the econf #3976
Conversation
WalkthroughWalkthroughA normalization step has been added to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant get_econf_tebd
participant econf_tebd
participant embed_input_dim
User ->> get_econf_tebd: Call get_econf_tebd(type_map, precision)
get_econf_tebd ->> econf_tebd: Compute econf_tebd
get_econf_tebd ->> econf_tebd: Normalize econf_tebd by its sum
econf_tebd -->> get_econf_tebd: Normalized econf_tebd
get_econf_tebd -->> User: Return normalized econf_tebd and embed_input_dim
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #3976 +/- ##
=======================================
Coverage 82.83% 82.83%
=======================================
Files 522 522
Lines 50871 50872 +1
Branches 3015 3015
=======================================
+ Hits 42137 42139 +2
+ Misses 7797 7795 -2
- Partials 937 938 +1 ☔ View full report in Codecov by Sentry. |
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Improvements** - Enhanced the accuracy of energy configuration embeddings by adding a normalization step. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Summary by CodeRabbit