-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a reminder for the illegal memory error #3822
Add a reminder for the illegal memory error #3822
Conversation
…ersion of neighbor stat.
for more information, see https://pre-commit.ci
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: Yifan Li李一帆 <[email protected]>
WalkthroughWalkthroughA log message has been introduced in the Changes
Tip New Features and ImprovementsReview SettingsIntroduced new personality profiles for code reviews. Users can now select between "Chill" and "Assertive" review tones to tailor feedback styles according to their preferences. The "Assertive" profile posts more comments and nitpicks the code more aggressively, while the "Chill" profile is more relaxed and posts fewer comments. AST-based InstructionsCodeRabbit offers customizing reviews based on the Abstract Syntax Tree (AST) pattern matching. Read more about AST-based instructions in the documentation. Community-driven AST-based RulesWe are kicking off a community-driven initiative to create and share AST-based rules. Users can now contribute their AST-based rules to detect security vulnerabilities, code smells, and anti-patterns. Please see the ast-grep-essentials repository for more information. New Static Analysis ToolsWe are continually expanding our support for static analysis tools. We have added support for Tone SettingsUsers can now customize CodeRabbit to review code in the style of their favorite characters or personalities. Here are some of our favorite examples:
Revamped Settings PageWe have redesigned the settings page for a more intuitive layout, enabling users to find and adjust settings quickly. This change was long overdue; it not only improves the user experience but also allows our development team to add more settings in the future with ease. Going forward, the changes to Miscellaneous
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review due to trivial changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
d754672
When using the GPU version of the neighbor stat code, one may encounter the following issue and the training will stop: ``` [2024-05-24 23:00:42,027] DEEPMD INFO Adjust batch size from 1024 to 2048 [2024-05-24 23:00:42,139] DEEPMD INFO Adjust batch size from 2048 to 4096 [2024-05-24 23:00:42,285] DEEPMD INFO Adjust batch size from 4096 to 8192 [2024-05-24 23:00:42,628] DEEPMD INFO Adjust batch size from 8192 to 16384 [2024-05-24 23:00:43,180] DEEPMD INFO Adjust batch size from 16384 to 32768 [2024-05-24 23:00:44,341] DEEPMD INFO Adjust batch size from 32768 to 65536 [2024-05-24 23:00:46,713] DEEPMD INFO Adjust batch size from 65536 to 131072 2024-05-24 23:00:52.071120: E tensorflow/compiler/xla/stream_executor/cuda/cuda_event.cc:29] Error polling for event status: failed to query event: CUDA_ERROR_ILLEGAL_ADDRESS: an illegal memory access was encountered 2024-05-24 23:00:52.075435: F tensorflow/core/common_runtime/device/device_event_mgr.cc:223] Unexpected Event status: 1 /bin/sh: line 1: 1397100 Aborted ``` This should be due to some issue of TensorFlow. One may use the environment variable `DP_INFER_BATCH_SIZE` to avoid this issue. This PR remind the user to set a small `DP_INFER_BATCH_SIZE` to avoid this issue. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> - **Bug Fixes** - Added a log message to guide users on setting the `DP_INFER_BATCH_SIZE` environment variable to avoid TensorFlow illegal memory access issues. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Yifan Li李一帆 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> (cherry picked from commit d754672) Signed-off-by: Jinzhe Zeng <[email protected]>
When using the GPU version of the neighbor stat code, one may encounter the following issue and the training will stop: ``` [2024-05-24 23:00:42,027] DEEPMD INFO Adjust batch size from 1024 to 2048 [2024-05-24 23:00:42,139] DEEPMD INFO Adjust batch size from 2048 to 4096 [2024-05-24 23:00:42,285] DEEPMD INFO Adjust batch size from 4096 to 8192 [2024-05-24 23:00:42,628] DEEPMD INFO Adjust batch size from 8192 to 16384 [2024-05-24 23:00:43,180] DEEPMD INFO Adjust batch size from 16384 to 32768 [2024-05-24 23:00:44,341] DEEPMD INFO Adjust batch size from 32768 to 65536 [2024-05-24 23:00:46,713] DEEPMD INFO Adjust batch size from 65536 to 131072 2024-05-24 23:00:52.071120: E tensorflow/compiler/xla/stream_executor/cuda/cuda_event.cc:29] Error polling for event status: failed to query event: CUDA_ERROR_ILLEGAL_ADDRESS: an illegal memory access was encountered 2024-05-24 23:00:52.075435: F tensorflow/core/common_runtime/device/device_event_mgr.cc:223] Unexpected Event status: 1 /bin/sh: line 1: 1397100 Aborted ``` This should be due to some issue of TensorFlow. One may use the environment variable `DP_INFER_BATCH_SIZE` to avoid this issue. This PR remind the user to set a small `DP_INFER_BATCH_SIZE` to avoid this issue. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> - **Bug Fixes** - Added a log message to guide users on setting the `DP_INFER_BATCH_SIZE` environment variable to avoid TensorFlow illegal memory access issues. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Yifan Li李一帆 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> (cherry picked from commit d754672) Signed-off-by: Jinzhe Zeng <[email protected]>
When using the GPU version of the neighbor stat code, one may encounter the following issue and the training will stop: ``` [2024-05-24 23:00:42,027] DEEPMD INFO Adjust batch size from 1024 to 2048 [2024-05-24 23:00:42,139] DEEPMD INFO Adjust batch size from 2048 to 4096 [2024-05-24 23:00:42,285] DEEPMD INFO Adjust batch size from 4096 to 8192 [2024-05-24 23:00:42,628] DEEPMD INFO Adjust batch size from 8192 to 16384 [2024-05-24 23:00:43,180] DEEPMD INFO Adjust batch size from 16384 to 32768 [2024-05-24 23:00:44,341] DEEPMD INFO Adjust batch size from 32768 to 65536 [2024-05-24 23:00:46,713] DEEPMD INFO Adjust batch size from 65536 to 131072 2024-05-24 23:00:52.071120: E tensorflow/compiler/xla/stream_executor/cuda/cuda_event.cc:29] Error polling for event status: failed to query event: CUDA_ERROR_ILLEGAL_ADDRESS: an illegal memory access was encountered 2024-05-24 23:00:52.075435: F tensorflow/core/common_runtime/device/device_event_mgr.cc:223] Unexpected Event status: 1 /bin/sh: line 1: 1397100 Aborted ``` This should be due to some issue of TensorFlow. One may use the environment variable `DP_INFER_BATCH_SIZE` to avoid this issue. This PR remind the user to set a small `DP_INFER_BATCH_SIZE` to avoid this issue. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Added a log message to guide users on setting the `DP_INFER_BATCH_SIZE` environment variable to avoid TensorFlow illegal memory access issues. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Yifan Li李一帆 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…under tf (#4283) #3822 added a reminder for the illegal memory error. However, this reminder is only needed for tf. This PR moves the illegal memory reminder from base class AutoBatchSize to the inherited class under tf. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced `AutoBatchSize` class to initialize batch size from an environment variable, improving user guidance on memory management with TensorFlow. - **Bug Fixes** - Removed redundant logging during initialization to streamline the process when GPU resources are available. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
When using the GPU version of the neighbor stat code, one may encounter the following issue and the training will stop:
This should be due to some issue of TensorFlow. One may use the environment variable
DP_INFER_BATCH_SIZE
to avoid this issue.This PR remind the user to set a small
DP_INFER_BATCH_SIZE
to avoid this issue.Summary by CodeRabbit
DP_INFER_BATCH_SIZE
environment variable to avoid TensorFlow illegal memory access issues.