Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: speed up Python test #3776

Merged
merged 6 commits into from
May 13, 2024

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented May 13, 2024

Reduce installation time from 2.5 min to 1.5 min.

Summary by CodeRabbit

  • Refactor
    • Enhanced Python environment setup and package installation processes to improve performance and compatibility.
  • Chores
    • Updated package management commands to ensure the latest versions of necessary libraries are used.

njzjz added 6 commits May 13, 2024 00:55
Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
Copy link
Contributor

coderabbitai bot commented May 13, 2024

Walkthrough

Walkthrough

The recent modifications enhance the Python testing environment in the GitHub workflow. The changes focus on refining the setup and installation process for specific Python packages, particularly Horovod and MPI4py, tailored to different TensorFlow versions. This includes adjustments to environment variables and installation commands to optimize compatibility and performance.

Changes

File Path Change Summary
.github/.../test_python.yml Removed usage of mpi4py/setup-mpi@v1, updated installation commands for Horovod, MPI4py, and MPICH, and adjusted TensorFlow version settings based on Python version. Added UV_EXTRA_INDEX_URL for specific package sources.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 4ab6436 and 06e7c2d.
Files selected for processing (1)
  • .github/workflows/test_python.yml (1 hunks)
Additional comments not posted (2)
.github/workflows/test_python.yml (2)

27-27: Ensure compatibility of TensorFlow with the specified Python versions.


33-33: Good use of dynamic environment settings to manage TensorFlow versions.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Out of diff range and nitpick comments (1)
.github/workflows/test_python.yml (1)

35-35: Add documentation for UV_EXTRA_INDEX_URL to clarify its purpose and usage.

@wanghan-iapcm wanghan-iapcm enabled auto-merge May 13, 2024 09:51
@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue May 13, 2024
Merged via the queue into deepmodeling:devel with commit dac3a3c May 13, 2024
52 checks passed
@njzjz njzjz modified the milestones: v3.0.0, v2.2.11 Jul 2, 2024
mtaillefumier pushed a commit to mtaillefumier/deepmd-kit that referenced this pull request Sep 18, 2024
Reduce installation time from 2.5 min to 1.5 min.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Enhanced Python environment setup and package installation processes
to improve performance and compatibility.
- **Chores**
- Updated package management commands to ensure the latest versions of
necessary libraries are used.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Jinzhe Zeng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants