-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: move init_models to setUpModule #3715
Conversation
so that the setup timing will be shown correctly Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
WalkthroughWalkthroughThe recent modifications across various test files primarily involve restructuring the initialization of global variables. This has been standardized by moving these initializations into the Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (2)
Additional comments not posted (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #3715 +/- ##
===========================================
- Coverage 82.19% 72.07% -10.12%
===========================================
Files 513 513
Lines 47642 47639 -3
Branches 2979 2980 +1
===========================================
- Hits 39159 34336 -4823
- Misses 7572 12481 +4909
+ Partials 911 822 -89 ☔ View full report in Codecov by Sentry. |
Split each pytest job into 6 separated jobs in GHA. Currently, each separated job takes: - ~2.5 min for installation, which may need to be optimized in the future; - ~2 min for setup, which may be a defect and should be resolved in #3715; - 4~5 min for tests (expected). --------- Signed-off-by: Jinzhe Zeng <[email protected]>
It looks to me like something went wrong in |
Signed-off-by: Jinzhe Zeng <[email protected]>
) Split each pytest job into 6 separated jobs in GHA. Currently, each separated job takes: - ~2.5 min for installation, which may need to be optimized in the future; - ~2 min for setup, which may be a defect and should be resolved in deepmodeling#3715; - 4~5 min for tests (expected). --------- Signed-off-by: Jinzhe Zeng <[email protected]>
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Enhanced the initialization process of global variables across multiple test modules to improve test setup efficiency and consistency. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Jinzhe Zeng <[email protected]> Co-authored-by: Han Wang <[email protected]>
Summary by CodeRabbit