Chore: refactor dpmodel #3663
Merged
Chore: refactor dpmodel #3663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #3663 +/- ##
==========================================
+ Coverage 81.87% 81.89% +0.02%
==========================================
Files 503 508 +5
Lines 46570 46635 +65
Branches 2952 2952
==========================================
+ Hits 38129 38192 +63
- Misses 7548 7550 +2
Partials 893 893 ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
anyangml
requested review from
wanghan-iapcm and
njzjz
and removed request for
wanghan-iapcm
njzjz
requested changes
Apr 11, 2024
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
@njzjz , it seems removing |
for more information, see https://pre-commit.ci
njzjz
requested changes
Apr 14, 2024
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
njzjz
reviewed
Apr 14, 2024
for more information, see https://pre-commit.ci
njzjz
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To decouple Model from DPAtomicModel, allowing make_model on different atomic model.