Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: migrate and refactor polar and dos bias #3662

Merged
merged 28 commits into from
Apr 18, 2024

Conversation

anyangml
Copy link
Collaborator

@anyangml anyangml commented Apr 10, 2024

  • remove polar and dos bias from fitting net
  • update apply bias
  • update UT for polar stat

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.89%. Comparing base (a04b46d) to head (e57dd7d).

Files Patch % Lines
deepmd/tf/loss/tensor.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #3662   +/-   ##
=======================================
  Coverage   81.89%   81.89%           
=======================================
  Files         508      508           
  Lines       46636    46585   -51     
  Branches     2952     2952           
=======================================
- Hits        38192    38152   -40     
+ Misses       7551     7540   -11     
  Partials      893      893           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anyangml
Copy link
Collaborator Author

@njzjz take a look, I think this will convert all atomic_*** labels to atom_*** without a breaking change.

@njzjz
Copy link
Member

njzjz commented Apr 10, 2024

@njzjz take a look, I think this will convert all atomic_*** labels to atom_*** without a breaking change.

I approve, but it seems the PR title is unrelated, right?

@anyangml anyangml marked this pull request as draft April 11, 2024 01:49
@anyangml anyangml marked this pull request as ready for review April 17, 2024 07:38
source/tests/pt/model/test_atomic_model_atomic_stat.py Outdated Show resolved Hide resolved
deepmd/utils/data.py Outdated Show resolved Hide resolved
@anyangml anyangml added this pull request to the merge queue Apr 18, 2024
Merged via the queue into deepmodeling:devel with commit f550f24 Apr 18, 2024
48 checks passed
@anyangml anyangml deleted the chore/migrate-bias branch April 18, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants