feat(pt): allow using directories to store stat #3633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the stat file endswith .h5 or .hdf5, an HDF5 file is used; otherwise, a directory containing NumPy binary files is used. Signed-off-by: Jinzhe Zeng <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #3633 +/- ##
==========================================
- Coverage 77.80% 77.79% -0.01%
==========================================
Files 438 438
Lines 37707 37707
Branches 1623 1623
==========================================
- Hits 29337 29335 -2
- Misses 7506 7508 +2
Partials 864 864 ☔ View full report in Codecov by Sentry. |
wanghan-iapcm
approved these changes
Apr 2, 2024
iProzd
approved these changes
Apr 2, 2024
|
Is 'saving to numpy directory' tested in UT? |
This was added in #3631 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the stat file ends with .h5 or .hdf5, an HDF5 file is used; otherwise, a directory containing NumPy binary files is used. This gives flexibility to users.