pt: add explicit decay_rate for lr #3445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #3445 +/- ##
==========================================
+ Coverage 77.49% 77.63% +0.13%
==========================================
Files 432 399 -33
Lines 37164 32365 -4799
Branches 1620 909 -711
==========================================
- Hits 28801 25127 -3674
+ Misses 7495 6710 -785
+ Partials 868 528 -340 ☔ View full report in Codecov by Sentry. |
wanghan-iapcm
requested changes
Mar 11, 2024
njzjz
requested changes
Mar 11, 2024
iProzd
changed the title
njzjz
approved these changes
Mar 13, 2024
wanghan-iapcm
requested changes
Mar 14, 2024
wanghan-iapcm
approved these changes
Mar 20, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for multitask training, when explicitly setting decay_rate is much more convenient for long training.