Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recovered all the skipped test for hybrid descriptor #3400

Merged
merged 3 commits into from
Mar 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions deepmd/dpmodel/descriptor/hybrid.py
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@
"""
out_descriptor = []
out_gr = []
out_g2 = []
out_g2 = None

Check warning on line 179 in deepmd/dpmodel/descriptor/hybrid.py

View check run for this annotation

Codecov / codecov/patch

deepmd/dpmodel/descriptor/hybrid.py#L179

Added line #L179 was not covered by tests
out_h2 = None
out_sw = None
if self.sel_no_mixed_types is not None:
Expand All @@ -199,15 +199,9 @@
out_descriptor.append(odescriptor)
if gr is not None:
out_gr.append(gr)
if g2 is not None:
out_g2.append(g2)
if self.get_rcut() == descrpt.get_rcut():
out_h2 = h2
out_sw = sw

out_descriptor = np.concatenate(out_descriptor, axis=-1)
out_gr = np.concatenate(out_gr, axis=-2) if out_gr else None
out_g2 = np.concatenate(out_g2, axis=-1) if out_g2 else None
return out_descriptor, out_gr, out_g2, out_h2, out_sw

@classmethod
Expand Down
8 changes: 1 addition & 7 deletions deepmd/pt/model/descriptor/hybrid.py
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@
"""
out_descriptor = []
out_gr = []
out_g2 = []
out_g2: Optional[torch.Tensor] = None

Check warning on line 203 in deepmd/pt/model/descriptor/hybrid.py

View check run for this annotation

Codecov / codecov/patch

deepmd/pt/model/descriptor/hybrid.py#L203

Added line #L203 was not covered by tests
out_h2: Optional[torch.Tensor] = None
out_sw: Optional[torch.Tensor] = None
if self.sel_no_mixed_types is not None:
Expand All @@ -225,14 +225,8 @@
out_descriptor.append(odescriptor)
if gr is not None:
out_gr.append(gr)
if g2 is not None:
out_g2.append(g2)
if self.get_rcut() == descrpt.get_rcut():
out_h2 = h2
out_sw = sw
out_descriptor = torch.cat(out_descriptor, dim=-1)
out_gr = torch.cat(out_gr, dim=-2) if out_gr else None
out_g2 = torch.cat(out_g2, dim=-1) if out_g2 else None
return out_descriptor, out_gr, out_g2, out_h2, out_sw

@classmethod
Expand Down
15 changes: 15 additions & 0 deletions source/tests/pt/model/test_autodiff.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
eval_model,
model_dpa1,
model_dpa2,
model_hybrid,
model_se_e2_a,
model_zbl,
)
Expand Down Expand Up @@ -192,6 +193,20 @@ def setUp(self):
self.model = get_model(model_params).to(env.DEVICE)


class TestEnergyModelHybridForce(unittest.TestCase, ForceTest):
def setUp(self):
model_params = copy.deepcopy(model_hybrid)
self.type_split = True
self.model = get_model(model_params).to(env.DEVICE)


class TestEnergyModelHybridVirial(unittest.TestCase, VirialTest):
def setUp(self):
model_params = copy.deepcopy(model_hybrid)
self.type_split = True
self.model = get_model(model_params).to(env.DEVICE)


class TestEnergyModelZBLForce(unittest.TestCase, ForceTest):
def setUp(self):
model_params = copy.deepcopy(model_zbl)
Expand Down
4 changes: 1 addition & 3 deletions source/tests/pt/model/test_jit.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ def tearDown(self):
JITTest.tearDown(self)


@unittest.skip("hybrid not supported at the moment")
class TestEnergyModelHybrid(unittest.TestCase, JITTest):
def setUp(self):
input_json = str(Path(__file__).parent / "water/se_atten.json")
Expand All @@ -118,7 +117,6 @@ def tearDown(self):
JITTest.tearDown(self)


@unittest.skip("hybrid not supported at the moment")
class TestEnergyModelHybrid2(unittest.TestCase, JITTest):
def setUp(self):
input_json = str(Path(__file__).parent / "water/se_atten.json")
Expand All @@ -128,7 +126,7 @@ def setUp(self):
self.config["training"]["training_data"]["systems"] = data_file
self.config["training"]["validation_data"]["systems"] = data_file
self.config["model"] = deepcopy(model_hybrid)
self.config["model"]["descriptor"]["hybrid_mode"] = "sequential"
# self.config["model"]["descriptor"]["hybrid_mode"] = "sequential"
self.config["training"]["numb_steps"] = 10
self.config["training"]["save_freq"] = 10

Expand Down
2 changes: 0 additions & 2 deletions source/tests/pt/model/test_null_input.py
Original file line number Diff line number Diff line change
Expand Up @@ -119,15 +119,13 @@ def setUp(self):
self.model = get_model(model_params).to(env.DEVICE)


@unittest.skip("hybrid not supported at the moment")
class TestEnergyModelHybrid(unittest.TestCase, NullTest):
def setUp(self):
model_params = copy.deepcopy(model_hybrid)
self.type_split = True
self.model = get_model(model_params).to(env.DEVICE)


@unittest.skip("hybrid not supported at the moment")
class TestForceModelHybrid(unittest.TestCase, NullTest):
def setUp(self):
model_params = copy.deepcopy(model_hybrid)
Expand Down
2 changes: 0 additions & 2 deletions source/tests/pt/model/test_permutation.py
Original file line number Diff line number Diff line change
Expand Up @@ -279,15 +279,13 @@ def setUp(self):
self.model = get_model(model_params).to(env.DEVICE)


@unittest.skip("hybrid not supported at the moment")
class TestEnergyModelHybrid(unittest.TestCase, PermutationTest):
def setUp(self):
model_params = copy.deepcopy(model_hybrid)
self.type_split = True
self.model = get_model(model_params).to(env.DEVICE)


@unittest.skip("hybrid not supported at the moment")
class TestForceModelHybrid(unittest.TestCase, PermutationTest):
def setUp(self):
model_params = copy.deepcopy(model_hybrid)
Expand Down
2 changes: 0 additions & 2 deletions source/tests/pt/model/test_rot.py
Original file line number Diff line number Diff line change
Expand Up @@ -154,15 +154,13 @@ def setUp(self):
self.model = get_model(model_params).to(env.DEVICE)


@unittest.skip("hybrid not supported at the moment")
class TestEnergyModelHybrid(unittest.TestCase, RotTest):
def setUp(self):
model_params = copy.deepcopy(model_hybrid)
self.type_split = True
self.model = get_model(model_params).to(env.DEVICE)


@unittest.skip("hybrid not supported at the moment")
class TestForceModelHybrid(unittest.TestCase, RotTest):
def setUp(self):
model_params = copy.deepcopy(model_hybrid)
Expand Down
1 change: 0 additions & 1 deletion source/tests/pt/model/test_smooth.py
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,6 @@ def setUp(self):
self.epsilon, self.aprec = None, None


@unittest.skip("hybrid not supported at the moment")
class TestEnergyModelHybrid(unittest.TestCase, SmoothTest):
def setUp(self):
model_params = copy.deepcopy(model_hybrid)
Expand Down
2 changes: 0 additions & 2 deletions source/tests/pt/model/test_trans.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,15 +110,13 @@ def setUp(self):
self.model = get_model(model_params).to(env.DEVICE)


@unittest.skip("hybrid not supported at the moment")
class TestEnergyModelHybrid(unittest.TestCase, TransTest):
def setUp(self):
model_params = copy.deepcopy(model_hybrid)
self.type_split = True
self.model = get_model(model_params).to(env.DEVICE)


@unittest.skip("hybrid not supported at the moment")
class TestForceModelHybrid(unittest.TestCase, TransTest):
def setUp(self):
model_params = copy.deepcopy(model_hybrid)
Expand Down