Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipi: remove normalize_coord #3257

Merged
merged 4 commits into from
Feb 11, 2024
Merged

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Feb 11, 2024

(1) Remove normalize_coord and add a test to confirm it still works;
(2) Remove the include of SimulationRegion.h and the direct link to libdeepmd.so;
(3) Allow using a pre-compiled C library to build dp_ipi.

Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
Copy link

codecov bot commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0e2304f) 75.27% compared to head (1c28f4d) 75.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3257      +/-   ##
==========================================
- Coverage   75.27%   75.27%   -0.01%     
==========================================
  Files         373      373              
  Lines       33238    33224      -14     
  Branches     1608     1605       -3     
==========================================
- Hits        25020    25009      -11     
+ Misses       7345     7344       -1     
+ Partials      873      871       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm wanghan-iapcm merged commit c131c8f into deepmodeling:devel Feb 11, 2024
46 checks passed
@njzjz njzjz mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants