breaking: pt: remove data stat from model init #3245
Conversation
Restore deepmodeling#3233 with resolved conflicts and conversations.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## devel #3245 +/- ##
==========================================
+ Coverage 75.19% 75.30% +0.10%
==========================================
Files 372 372
Lines 33136 33220 +84
Branches 1608 1608
==========================================
+ Hits 24916 25015 +99
+ Misses 7347 7332 -15
Partials 873 873 ☔ View full report in Codecov by Sentry. |
source/tests/pt/test_stat.py has the UTs to compare the consistence of data stats between tf and pt, on both descriptor and fitting but only on se_a model. |
Signed-off-by: Duo <[email protected]>
for more information, see https://pre-commit.ci
|
|
||
| def init_desc_stat(self, sumr, suma, sumn, sumr2, suma2): | ||
| def init_desc_stat(self, sumr, suma, sumn, sumr2, suma2, **kwargs): |
Check warning
Code scanning / CodeQL
Signature mismatch in overriding method Warning
|
|
||
| def init_desc_stat(self, sumr, suma, sumn, sumr2, suma2): | ||
| def init_desc_stat(self, sumr, suma, sumn, sumr2, suma2, **kwargs): |
Check warning
Code scanning / CodeQL
Signature mismatch in overriding method Warning
|
|
||
| def init_desc_stat(self, sumr, suma, sumn, sumr2, suma2): | ||
| def init_desc_stat(self, sumr, suma, sumn, sumr2, suma2, **kwargs): |
Check warning
Code scanning / CodeQL
Signature mismatch in overriding method Warning
Restore deepmodeling#3233 with resolved conflicts and conversations. This PR clean up the data stat process from model init. Please note that this code PR is just an initial cleanup and refinement of the data stat, and a more detailed design of the data stat will be completed in the next PR: - independent data stat from dataloader - data stat support for hybrid descriptors --------- Signed-off-by: Duo <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Restore #3233 with resolved conflicts and conversations.
This PR clean up the data stat process from model init.
Please note that this code PR is just an initial cleanup and refinement of the data stat, and a more detailed design of the data stat will be completed in the next PR: