cmake: fix setting CMAKE_HIP_FLAGS
#3155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CMAKE_<LANG>_FLAGS` is a string, so when using `set`, we should use quotes.
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #3155 +/- ##
=======================================
Coverage 76.05% 76.05%
=======================================
Files 276 276
Lines 25586 25586
Branches 1591 1595 +4
=======================================
Hits 19460 19460
Misses 5202 5202
Partials 924 924 ☔ View full report in Codecov by Sentry. |
wanghan-iapcm
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2523 (comment).
CMAKE_<LANG>_FLAGSis a string, so when usingset, we should use quotes.