fix se_a compression for just enough sel and symmetrical coordinates #2924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this case, when `em_x` is equal to the last neighbor, `em` may not. This patch checks whether em is zero, which means sel is larger than the actual neighbor number. Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
github-actions
bot
added
Core
CUDA
ROCM
and removed
Test CUDA
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #2924 +/- ##
==========================================
+ Coverage 75.36% 75.77% +0.40%
==========================================
Files 245 246 +1
Lines 24648 25048 +400
Branches 1582 1618 +36
==========================================
+ Hits 18577 18979 +402
+ Misses 5140 5104 -36
- Partials 931 965 +34
☔ View full report in Codecov by Sentry. |
denghuilu
approved these changes
Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this case, when
em_xis equal to the last neighbor,emmay not.This patch checks whether em[1] ~ [3] is zero. In the current se_a implementation, they are zero only when they are padded zero.