Skip to content

Commit

Permalink
move get_model_def_script to make_base_atomic_model
Browse files Browse the repository at this point in the history
Signed-off-by: Jinzhe Zeng <[email protected]>
  • Loading branch information
njzjz committed Feb 27, 2024
1 parent fbd1300 commit d3ef0a4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 4 additions & 0 deletions deepmd/dpmodel/atomic_model/make_base_atomic_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,10 @@ def do_grad_(self, var_name: str, base: str) -> bool:
return self.fitting_output_def()[var_name].c_differentiable
return self.fitting_output_def()[var_name].r_differentiable

def get_model_def_script(self) -> str:
# TODO: implement this method; saved to model
raise NotImplementedError

Check warning on line 165 in deepmd/dpmodel/atomic_model/make_base_atomic_model.py

View check run for this annotation

Codecov / codecov/patch

deepmd/dpmodel/atomic_model/make_base_atomic_model.py#L165

Added line #L165 was not covered by tests

setattr(BAM, fwd_method_name, BAM.fwd)
delattr(BAM, "fwd")

Expand Down
4 changes: 0 additions & 4 deletions deepmd/dpmodel/model/base_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,3 @@ class BaseModel(make_base_model()):
deepmd.dpmodel.model.base_model.BaseBaseModel
Backend-independent BaseModel class.
"""

def get_model_def_script(self) -> str:
# TODO: implement this method; saved to model
raise NotImplementedError

0 comments on commit d3ef0a4

Please sign in to comment.