Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor:remove GlobalC::ucell in module_elesctate #5730

Merged
merged 22 commits into from
Dec 16, 2024
Merged

Refactor:remove GlobalC::ucell in module_elesctate #5730

merged 22 commits into from
Dec 16, 2024

Conversation

A-006
Copy link
Collaborator

@A-006 A-006 commented Dec 13, 2024

Unit Tests and/or Case Tests for my changes

  • fix bug in the unit test of the module_elecstate.

What's changed?

  • Remove GlobalC::ucell in the module_elecstate.
  • remove file in the module_elecstate/elecstate_getters.cpp

@A-006 A-006 marked this pull request as draft December 16, 2024 01:56
@mohanchen mohanchen added the The Absolute Zero Reduce the "entropy" of the code to 0 label Dec 16, 2024
@A-006 A-006 marked this pull request as ready for review December 16, 2024 07:47
@mohanchen
Copy link
Collaborator

Good job.

@mohanchen mohanchen merged commit 815bff5 into deepmodeling:develop Dec 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohanchen mohanchen mohanchen approved these changes

Assignees
No one assigned
Labels
The Absolute Zero Reduce the "entropy" of the code to 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@A-006 @mohanchen