Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Remove the functions about pseudopotential from Unitcell. #5673

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

sunliang98
Copy link
Collaborator

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #...

Unit Tests and/or Case Tests for my changes

  • Update the corresponding Unit Tests.

What's changed?

  • Remove read_pseudo and read_cell_pseudopots from Unitcell.
  • Remove print_unitcell_pseudo from UnitCell.
  • Delete module_cell/read_cell_pseudopots.cpp.

TODO:

  • Remove the files about reading PP from module_cell.

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@mohanchen mohanchen added the The Absolute Zero Reduce the "entropy" of the code to 0 label Dec 3, 2024
@mohanchen mohanchen merged commit 6d26194 into deepmodeling:develop Dec 5, 2024
14 checks passed
@sunliang98 sunliang98 deleted the pp branch December 6, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
The Absolute Zero Reduce the "entropy" of the code to 0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants