Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional explanations to the example files and fixing result.ref file in examples/bsse/water #5484

Merged
merged 9 commits into from
Nov 14, 2024

Conversation

BariumOxide13716
Copy link
Collaborator

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #5472

Unit Tests and/or Case Tests for my changes

Unit tests not required

What's changed?

My changes updates the examples/bsse/water/result.ref file such that run.sh reports "job succeeded" after it is executed.
Some comments are added to the example INPUT and KPT files to more clearly explain what is happening in these files.

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@BariumOxide13716
Copy link
Collaborator Author

hi @maki49 and @pxlxingliang , could you please help review the changes made in these files and let me know if any changes need to be made?

@mohanchen mohanchen merged commit d3aa439 into deepmodeling:develop Nov 14, 2024
14 checks passed
@mohanchen mohanchen added the Refactor Refactor ABACUS codes label Nov 14, 2024
@BariumOxide13716 BariumOxide13716 deleted the prbranch branch November 22, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Refactor ABACUS codes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weekly example test is failed at 20241113
3 participants