Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: performance and memory for NSPIN=4 in LCAO base #5249

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

dyzheng
Copy link
Collaborator

@dyzheng dyzheng commented Oct 16, 2024

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #5250

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

  • fix the waste of performance and memory in cal_DMR for NSPIN=4
  • performance of Si256 first scf step from 326 s to 31.2 s

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@mohanchen mohanchen added the Performance Issues related to fail running ABACUS label Oct 16, 2024
@mohanchen mohanchen merged commit 50a204f into deepmodeling:develop Oct 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Issues related to fail running ABACUS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DensityMatrix::cal_DMR() with nspin=4 is significantly slower than nspin=1
2 participants