forked from abacusmodeling/abacus-develop
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: RI-Hartree for LR-TDDFT benchmark with FHI-aims #5084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maki49
force-pushed
the
ri-benchmark-rebased
branch
5 times, most recently
from
September 12, 2024 10:24
269e0f4
to
31a156e
Compare
mohanchen
reviewed
Sep 13, 2024
examples/lr-tddft/H2-RI-J-aims-benchmark/aims-files/Cs_data_0.txt
Outdated
Show resolved
Hide resolved
examples/lr-tddft/H2-RI-J-aims-benchmark/aims-files/coulomb_mat_0.txt
Outdated
Show resolved
Hide resolved
mohanchen
added
the
Feature Discussed
The features will be discussed first but will not be implemented soon
label
Sep 13, 2024
CV: io index consistent with aims ri-j for benchmark continue update RI_benchmark
maki49
force-pushed
the
ri-benchmark-rebased
branch
2 times, most recently
from
September 14, 2024 17:13
7d1e585
to
c37d492
Compare
maki49
force-pushed
the
ri-benchmark-rebased
branch
from
September 14, 2024 17:32
efb591f
to
08b6ab8
Compare
mohanchen
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the feature for
Read LRI$C$ -tensors and Coulomb matrix $V$ under FHI-aims' ABFs and KS-eigenstates $c$ under FHI-aims' NAOs into ABACUS, then transform the Coulomb matrix directly from ABFs to particle-hole basis by $c_ic_aCVCc_jc_b$ to get the Hartree term in Casida A matrix comparable with FHI-aims, bypassing the difference between the NAO basis set used in the two software.
What bugs have been found and fixed by this feature
ccp_type
that should be consistent withxc_kernel
Some test results
How to use it
See the addition in the documentation and the new example.
@Fisherd99 FYI