Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: remove GlobalC::ORB from module_io #5056

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Refactor: remove GlobalC::ORB from module_io #5056

merged 2 commits into from
Sep 6, 2024

Conversation

jinzx10
Copy link
Collaborator

@jinzx10 jinzx10 commented Sep 5, 2024

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

#4079

@jinzx10 jinzx10 added the The Absolute Zero Reduce the "entropy" of the code to 0 label Sep 5, 2024
@mohanchen mohanchen merged commit ce17c4a into deepmodeling:develop Sep 6, 2024
14 checks passed
@jinzx10 jinzx10 deleted the remove_GlobalC_ORB_stage_1 branch September 8, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohanchen mohanchen mohanchen approved these changes

Assignees
No one assigned
Labels
The Absolute Zero Reduce the "entropy" of the code to 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinzx10 @mohanchen