Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix the issue that out_chg -1 not really work #5046

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

kirk0830
Copy link
Collaborator

@kirk0830 kirk0830 commented Sep 4, 2024

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #5043

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@Fisherd99
Copy link

very good fix, make my out_chg -1 work👍🏼

@mohanchen mohanchen added the Input&Output Suitable for coders without knowing too many DFT details label Sep 4, 2024
@mohanchen mohanchen merged commit 9cd8d5f into deepmodeling:develop Sep 5, 2024
14 checks passed
@kirk0830 kirk0830 deleted the fix-rhog-out branch September 5, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Input&Output Suitable for coders without knowing too many DFT details
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: still dump ABACUS-CHARGE-DENSITY.restart even if set out_chg -1
3 participants