Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: remove uncessary interfaces in module_io #4835

Merged
merged 5 commits into from
Jul 31, 2024
Merged

Refactor: remove uncessary interfaces in module_io #4835

merged 5 commits into from
Jul 31, 2024

Conversation

YuLiu98
Copy link
Collaborator

@YuLiu98 YuLiu98 commented Jul 30, 2024

What's changed?

  • remove create_Output_Rho(), create_Output_Kin() in esolver_ks
  • remove write_rho() and write_pot()
  • rename write_pot to write_elecstat_pot
  • move CE to esolver_fp

@YuLiu98 YuLiu98 requested review from mohanchen and Qianruipku July 30, 2024 09:18
@mohanchen mohanchen added the The Absolute Zero Reduce the "entropy" of the code to 0 label Jul 31, 2024
@mohanchen mohanchen merged commit 0b97dbd into deepmodeling:develop Jul 31, 2024
14 checks passed
@YuLiu98 YuLiu98 deleted the after_scf branch July 31, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohanchen mohanchen mohanchen approved these changes

@Qianruipku Qianruipku Awaiting requested review from Qianruipku

Assignees
No one assigned
Labels
The Absolute Zero Reduce the "entropy" of the code to 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YuLiu98 @mohanchen