Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: add return value for mock in tests to suppress compile warning #4775

Merged

Conversation

Cstandardlib
Copy link
Collaborator

Linked Issue

Fix #4756

What's changed?

  • Add missing return value for mock in some tests to suppress compile warnings.
  • The relevant parts of gtest are left unchanged.
// like this
abacus-develop/source/module_elecstate/module_dm/test/test_cal_dm_R.cpp:77:10: warning: 'TearDown' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
   77 |     void TearDown()
      |          ^
/usr/local/include/gtest/gtest.h:315:16: note: overridden virtual function is here
  315 |   virtual void TearDown();
      |                ^

@Cstandardlib Cstandardlib requested a review from Qianruipku July 23, 2024 17:54
@mohanchen mohanchen merged commit 815017e into deepmodeling:develop Jul 24, 2024
14 checks passed
@mohanchen mohanchen added the The Absolute Zero Reduce the "entropy" of the code to 0 label Jul 24, 2024
@Cstandardlib Cstandardlib deleted the eliminate-compile-test-warnings branch July 24, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
The Absolute Zero Reduce the "entropy" of the code to 0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile warnings could be eliminated
2 participants