Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: compile failure of main.cpp #4638

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Fix: compile failure of main.cpp #4638

merged 3 commits into from
Jul 11, 2024

Conversation

Qianruipku
Copy link
Collaborator

@Qianruipku Qianruipku commented Jul 11, 2024 •
edited
Loading

Linked Issue

Fix #4637

After change

image

@caic99
Copy link
Member

caic99 commented Jul 11, 2024

@Qianruipku I would suggest moving the add_executable line after set(CMAKE_CXX_STANDARD) instead of creating a new lib

caic99
caic99 reviewed Jul 11, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@mohanchen mohanchen merged commit a115155 into deepmodeling:develop Jul 11, 2024
13 checks passed
@mohanchen mohanchen added the Compile & CICD & Docs & Dependencies Issues related to compiling ABACUS label Jul 11, 2024
@Qianruipku Qianruipku deleted the hotfix branch July 14, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caic99 caic99 caic99 approved these changes

Assignees
No one assigned
Labels
Compile & CICD & Docs & Dependencies Issues related to compiling ABACUS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gcc 5.4.0 cannot compile ABACUS
3 participants
@Qianruipku @caic99 @mohanchen