Refactor: remove Hloc, Hloc2, Sloc, Sloc2 in LCAO_Matrix

[dyzheng]

Reminder

• Have you linked an issue with this pull request?
• Have you added adequate unit tests and/or case tests for your pull request?
• Have you noticed possible changes of behavior below or in the linked issue?
• Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #...

Unit Tests and/or Case Tests for my changes

• A unit test is added for each new feature or bug fix.

What's changed?

• Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

• Example: I have added a new virtual function in the esolver base class in order to ...

[haozhihan]

Why didn't clang-tidy do the same wrong behavior as in commit d72d89d in commit db5ad46 in this PR, changing ModuleBase::timer to timex?

@caic99

[caic99]

Why didn't clang-tidy do the same wrong behavior as in commit d72d89d in commit db5ad46 in this PR, changing ModuleBase::timer to timex?

@caic99

@haozhihan I guess you are asking why the latest commit is correct, right? As you can see, timer.h is added to dftu_force_stress.hpp in the last commit, hence clang-tidy is able to know the existence of ModuleBase::timer.

Edit: the wrong modification above is the result of missing a header file, but not "random behavior of clang-tidy".

[dyzheng]

Why didn't clang-tidy do the same wrong behavior as in commit d72d89d in commit db5ad46 in this PR, changing ModuleBase::timer to timex?
@caic99

@haozhihan I guess you are asking why the latest commit is correct, right? As you can see, timer.h is added to dftu_force_stress.hpp in the last commit, hence clang-tidy is able to know the existence of ModuleBase::timer.

Edit: the wrong modification above is the result of missing a header file, but not "random behavior of clang-tidy".

The lack of header of timer.h won't cause any error in building test, which means header in included by other included headers. I don't think the related rule of clang-tidy is good.

[haozhihan]

Why didn't clang-tidy do the same wrong behavior as in commit d72d89d in commit db5ad46 in this PR, changing ModuleBase::timer to timex?
@caic99

@haozhihan I guess you are asking why the latest commit is correct, right? As you can see, timer.h is added to dftu_force_stress.hpp in the last commit, hence clang-tidy is able to know the existence of ModuleBase::timer.

Edit: the wrong modification above is the result of missing a header file, but not "random behavior of clang-tidy".

Thank you very much for your patience. I understand the reason for this matter.

Thank you very much again! @caic99

[caic99]

The lack of header of timer.h won't cause any error in building test, which means header in included by other included headers. I don't think the related rule of clang-tidy is good.

@dyzheng Well, I think it helped us to find a potential bug, although it is a compile-time one and easy to fix. Passing building test does not ensure 100% correctness.