Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix precommit failure #4426

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Conversation

caic99
Copy link
Member

@caic99 caic99 commented Jun 18, 2024

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #4422

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@haozhihan haozhihan added the Compile & CICD & Docs & Dependencies Issues related to compiling ABACUS label Jun 18, 2024
.github/workflows/test.yml Outdated Show resolved Hide resolved
@WHUweiqingzhou WHUweiqingzhou merged commit 44315da into deepmodeling:develop Jun 19, 2024
13 checks passed
@caic99 caic99 deleted the fix-precommit branch June 19, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compile & CICD & Docs & Dependencies Issues related to compiling ABACUS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: clang-tidy and clang-format do not work
3 participants