forked from abacusmodeling/abacus-develop
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: add alternatives to functions LOWF::gamma_file
and LOWF::allocate_k
#4331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirk0830
changed the title
Refactor: add alternatives to functions of
Refactor: add alternatives to functions Jun 7, 2024
LOWF::gamma_file
and LOWF::allocate_k
LOWF::gamma_file
and LOWF::allocate_k
mohanchen
reviewed
Jun 8, 2024
mohanchen
approved these changes
Jun 13, 2024
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Original functions
LOWF::gamma_file
andLOWF::allocate_k
are in mess, with quite bad design.In this PR I divide what those two functions do into parts:
std::vector
making it easy forpsi
instance construction, see the No.8 constructor. Therefore what I need to do next is to find place in ESolver workflow to let the initialization of wavefunction available.There is a unittest case a littble bit pedagogical, see unittest "Pzgemr2dUseTest".
Reminder
Linked Issue
Partially Fix #4303
Unit Tests and/or Case Tests for my changes
Any changes of core modules? (ignore if not applicable)