Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve output of H and S matrices: output matrices when the self-con… #4147

Merged
merged 1 commit into from
May 10, 2024

Conversation

LiuXiaohui123321
Copy link
Collaborator

…sistent iteration steps reach scf_nmax, even if the charge density doesn't converge.

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #4093

On top of the current code framework, I just simply add the output H and S matrices when the self-consistent iteration steps reach scf_nmax. However, I'm not quite sure if this will have an impact on the rest of the update_pot() function, which contains both the function to output the H and S matrices and a few other functions as well. Also, I think the function update_pot() is a bit unclear in its functionality.

…sistent iteration steps reach scf_nmax, even if the charge density doesn't converge.
@mohanchen mohanchen merged commit 7fdd771 into deepmodeling:develop May 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timing of the output of H and S matrices
3 participants