-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: set OpenMP thread num to a proper default value #3943
Conversation
Could someone please help me on this error building tests? |
@caic99 I have some test by using this repo. It worked well , but if the machine has hyper-thread (like WSL or bohrium image), the product of OMP number and MPI number will include hyper-thread and lead to lower parallel efficiency than the hardware-core (hyper-thread / 2) situation. |
It's hard to determine with standard c++ API whether hyperthreading is used. |
Any updates? |
Reminder
Linked Issue
Fix #3701
Unit Tests and/or Case Tests for my changes
What's changed?
ABACUS will try to set a proper OpenMP threading value if
OMP_NUM_THREADS
is not set, and exit with error if the value set is beyond hardware availability (which should not happen since the value has been automatically set).