Feature: Add INPUT parameter bands_to_print for LCAO basis set
#3934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsTonyshment
changed the title
out_band_indexout_band_index
mohanchen
reviewed
Apr 9, 2024
|
Is it possible to use same input parameters for PW and LCAO? |
Yes, this is what I'm doing at present. |
AsTonyshment
changed the title
out_band_indexbands_to_print for LCAO basis set
16 tasks
…cus-develop into fix-param-nbands-istate Fix several bugs of band-decomposed charge densities using PW basis set
… the corresponding docs
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issue
Fixes #2924 and #3266. Updates: Fixes #3947.
Partially implements feature support #3572.
What's changed?
bands_to_printfor LCAO basis set, akin toocp_set. This allows for selective band calculation when thecalculationkeyword is set toget_pchg.nbands_istatetemporarily ascalculation = get_wfremains unchanged.Notice
May potentially conflict with the naming in PR #3501 (PW basis set), which will be addressed and unified in subsequent updates.
Updates: Following @mohanchen's suggestion, I have standardized the INPUT parameter to
bands_to_print, and uniformly changed the input format to string. This has been updated accordingly in the PW basis set code. The docs has also been updated to reflect these changes. INPUT parameterband_print_numis deleted.