[ci] fix ci to test windows properly #3543
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The continuous workflow for windows is busted, and we've had a silent failure in that test for a long time.
The issue is that we run 3 separate tests in the final github step of continuous/build-windows, but the success/failure outcome is only dependent on the final command we run. Specifically, we run:
When this runs if the 3rd line succeeds, it hides any failure that occurs in the previous two lines.
This change refactors the continuous workflow by unifying the windows test into the existing mac/linux tests, which function as expected. The separate stage for windows may have made sense sometime in the past, it no longer needs to be separate.
I have also modified the nightly-publish workflow to ensure that we test all 3 major OS's across each of the suites. I have also specified fail-fast: false to ensure no short-circuiting of tests due to failures.