Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Fixes fasttext native build for nodejs20 issue #3478

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

xyang16
Copy link
Contributor

@xyang16 xyang16 commented Sep 17, 2024

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@xyang16 xyang16 requested review from zachgk, frankfliu and a team as code owners September 17, 2024 00:20
@@ -10,14 +10,14 @@ permissions:
jobs:
build-fasttext-jni-linux:
runs-on: ubuntu-latest
container: amazonlinux:2
container: amazonlinux:2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot upgrade to amazonlinux:2023 yet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All internal AWS customers are using AL2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Changed the checkout action.

@xyang16 xyang16 changed the title [ci] Update fasttext native build container [ci] Fixes fasttext native build for nodejs20 issue Sep 17, 2024
@xyang16 xyang16 merged commit 5362332 into deepjavalibrary:master Sep 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants