-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Make MPS default device for macOS M1 #2044
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportBase: 72.08% // Head: 69.61% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2044 +/- ##
============================================
- Coverage 72.08% 69.61% -2.48%
- Complexity 5126 5964 +838
============================================
Files 473 597 +124
Lines 21970 26510 +4540
Branches 2351 2884 +533
============================================
+ Hits 15838 18456 +2618
- Misses 4925 6664 +1739
- Partials 1207 1390 +183
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@@ -1544,6 +1544,10 @@ public static PtSymbolBlock loadModule( | |||
String[] extraFileKeys, | |||
String[] extraFileValues) { | |||
Device device = manager.getDevice(); | |||
// MPS doesn't support mapLocation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frankfliu - Could you please add the changes that disable "mapLocation" for "mps" to the master? This will improve the current "mps" support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created a PR: #2061
Currently MPS has many limitations:
.toDevice()
: _ZN2at6native3mps13copy_cast_mpsThis PR is just used as a reference, will make MPS default device when it become stable