Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation for Windows #217

Merged
merged 6 commits into from
Nov 12, 2020
Merged

Fix compilation for Windows #217

merged 6 commits into from
Nov 12, 2020

Conversation

MicheleCancilla
Copy link
Contributor

This PR solves some errors with Windows:

  1. #include <sys/time.h> has been wrapped using EDDL_WINDOWS macro.
  2. Some newer OpenMP directives have been omitted only for Windows, again using EDDL_WINDOWS macro.
  3. I updated the Jenkinsfile changing the base docker images. It should be useful for checking gpu-enabled tests of eddl.

salvacarrion
salvacarrion reviewed Nov 12, 2020
View reviewed changes
src/net/net_api.cpp Show resolved Hide resolved
src/hardware/cpu/cpu_comparison.cpp Show resolved Hide resolved
src/hardware/cpu/nn/cpu_losses.cpp Show resolved Hide resolved
src/CMakeLists.txt Outdated Show resolved Hide resolved
@salvacarrion salvacarrion merged commit a0b40d4 into deephealthproject:develop Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salvacarrion salvacarrion salvacarrion left review comments

Assignees
No one assigned
Labels
Windows support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MicheleCancilla @salvacarrion