Heap size UI #718
Merged
Heap size UI #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #718 +/- ##
========================================
Coverage 35.76% 35.76%
========================================
Files 399 400 +1
Lines 30213 30324 +111
Branches 7403 7445 +42
========================================
+ Hits 10805 10846 +41
- Misses 19332 19435 +103
+ Partials 76 43 -33
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dsmmcken
reviewed
Aug 15, 2022
dsmmcken
reviewed
Aug 15, 2022
dsmmcken
reviewed
Aug 15, 2022
dsmmcken
reviewed
Aug 15, 2022
| defaultUpdateInterval: 10000, | ||
| hoverUpdateInterval: 3000, | ||
| }} | ||
| monitorDuration={60 * 10} |
There was a problem hiding this comment.
Now I wonder if 10 minutes is too long, graph moves so slow. Maybe 5?
Thoughts?
There was a problem hiding this comment.
Windows task manager shows performance over 60s, so maybe we move to 5 minutes and double the poll rate?
|
Visually, looks great. |
dsmmcken
requested changes
Aug 15, 2022
mattrunyon
requested changes
Aug 16, 2022
- Exposed popper onEntered through tooltip component - Have tooltip onEntered/onExited manage isOpen state - Make tooltip interactive so it can be interacted with, copy text etc - Clean up css
mattrunyon
requested changes
Aug 19, 2022
mattrunyon
requested changes
Aug 25, 2022
mattrunyon
approved these changes
Aug 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #715
Added Heap size monitoring UI Component
Added Heap Size Display in Console