Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick plugin permissions from Enterprise #359

Merged
merged 3 commits into from
Dec 17, 2021

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Dec 17, 2021

Plugin permissions were implemented in an old version, cherrypick to DHC
https://deephaven.atlassian.net/browse/DH-11752
https://gitlab.eng.illumon.com/illumon/iris/merge_requests/6181/diffs

Fixes #326

@mofojed mofojed added enhancement New feature or request web-client-ui labels Dec 17, 2021
@mofojed mofojed added this to the December 2021 milestone Dec 17, 2021
@mofojed mofojed requested a review from vbabich December 17, 2021 16:07
@mofojed mofojed self-assigned this Dec 17, 2021
@mofojed
Copy link
Member Author

mofojed commented Dec 17, 2021

Breaking change with the change in PropTypes in jsapi-shim.

@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #359 (97ef364) into main (08ae91d) will increase coverage by 11.71%.
The diff coverage is 23.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##            main     #359       +/-   ##
==========================================
+ Coverage   5.66%   17.37%   +11.71%     
==========================================
  Files          2       51       +49     
  Lines        212     5514     +5302     
  Branches      35     1294     +1259     
==========================================
+ Hits          12      958      +946     
- Misses       200     4292     +4092     
- Partials       0      264      +264     
Flag Coverage Δ
unit 17.37% <23.52%> (+11.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/code-studio/src/main/AppInit.jsx 0.00% <0.00%> (ø)
...d/src/mousehandlers/IrisGridContextMenuHandler.jsx 3.61% <0.00%> (ø)
packages/utils/src/TestUtils.ts 42.85% <ø> (ø)
packages/iris-grid/src/IrisGrid.jsx 28.70% <17.85%> (ø)
packages/code-studio/src/main/AppMainContainer.jsx 30.53% <100.00%> (ø)
...ashboard-core-plugins/src/panels/IrisGridPanel.jsx 44.54% <100.00%> (ø)
...shboard-core-plugins/src/prop-types/UIPropTypes.js 100.00% <100.00%> (ø)
packages/console/src/ConsoleInput.jsx
packages/console/src/StoragePropTypes.js
...ckages/code-studio/src/main/WebdavLayoutStorage.ts 0.00% <0.00%> (ø)
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08ae91d...97ef364. Read the comment docs.

packages/jsapi-shim/src/PropTypes.js Outdated Show resolved Hide resolved
@mofojed mofojed requested a review from vbabich December 17, 2021 18:27
@mofojed mofojed merged commit 19c7d14 into deephaven:main Dec 17, 2021
@mofojed mofojed deleted the 326-permissions branch December 17, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cherry-pick plugin permissions from enterprise
2 participants