Don't trigger console csv upload overlay if dragging text #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dsmmcken
commented
Dec 9, 2021
dsmmcken
commented
- You can select text and drag it in a browser (kind == "string"), this shouldn't trigger the csv overlay
- Fix Button component proptype error with "type" other than button requiring an onClick function ex. (csv overlay bar, type=submit)
- Multiple file error should return, as filetype error can replace it
Codecov Report
@@ Coverage Diff @@
## main #344 +/- ##
=========================================
+ Coverage 0 10.32% +10.32%
=========================================
Files 0 9 +9
Lines 0 901 +901
Branches 0 159 +159
=========================================
+ Hits 0 93 +93
- Misses 0 802 +802
- Partials 0 6 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mofojed
requested changes
Dec 10, 2021
- You can select text and drag it in a browser (kind == "string"), this shouldn't trigger the csv overlay - Fix Button component proptype error with "type" other than button requiring an onClick function ex. (csv overlay bar, type=submit) - Multiple file error should return, as filetype error can replace it
dsmmcken
force-pushed
the
dmckenzie_csvOverlay
branch
from
0f86d7e to
db6ee42
Compare
|
Uh, just trying to make both defaultProps and typescript to work together for the type field, and extend the default react button types for everything else. |
mofojed
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.