Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freeze columns via context menu #321

Merged
merged 11 commits into from
Dec 17, 2021
Merged

Conversation

spasovski
Copy link
Contributor

No description provided.

packages/iris-grid/src/IrisGridProxyModel.js Outdated Show resolved Hide resolved
packages/iris-grid/src/IrisGridModelUpdater.jsx Outdated Show resolved Hide resolved
packages/iris-grid/src/IrisGridTableModel.js Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #321 (9fac4e7) into main (19c7d14) will increase coverage by 16.48%.
The diff coverage is 36.78%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #321       +/-   ##
===========================================
+ Coverage   17.37%   33.86%   +16.48%     
===========================================
  Files          51       32       -19     
  Lines        5514     5723      +209     
  Branches     1294     1341       +47     
===========================================
+ Hits          958     1938      +980     
+ Misses       4292     3531      -761     
+ Partials      264      254       -10     
Flag Coverage Δ
unit 33.86% <36.78%> (+16.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ashboard-core-plugins/src/panels/IrisGridPanel.jsx 44.54% <ø> (ø)
packages/iris-grid/src/IrisGrid.jsx 28.21% <0.00%> (-0.49%) ⬇️
packages/iris-grid/src/IrisGridModel.js 11.00% <0.00%> (-0.21%) ⬇️
packages/iris-grid/src/IrisGridUtils.js 46.11% <ø> (+34.95%) ⬆️
...d/src/mousehandlers/IrisGridContextMenuHandler.jsx 3.55% <0.00%> (-0.07%) ⬇️
packages/iris-grid/src/IrisGridTableModel.js 47.03% <50.90%> (ø)
packages/iris-grid/src/IrisGridModelUpdater.jsx 97.36% <100.00%> (+0.14%) ⬆️
packages/iris-grid/src/IrisGridProxyModel.js 62.35% <100.00%> (ø)
...e-studio/src/storage/PouchCommandHistoryStorage.ts
packages/code-studio/src/main/WidgetUtils.ts
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19c7d14...9fac4e7. Read the comment docs.

@spasovski spasovski marked this pull request as ready for review December 9, 2021 21:10
@spasovski spasovski added the enhancement New feature or request label Dec 9, 2021
@spasovski spasovski requested a review from mofojed December 9, 2021 21:10
@spasovski spasovski self-assigned this Dec 9, 2021
@spasovski spasovski changed the title freeze via context menu WIP freeze columns via context menu Dec 9, 2021
packages/iris-grid/src/IrisGrid.jsx Outdated Show resolved Hide resolved
packages/iris-grid/src/IrisGridTableModel.js Outdated Show resolved Hide resolved
packages/iris-grid/src/IrisGridTableModel.js Outdated Show resolved Hide resolved
packages/iris-grid/src/IrisGridTableModel.js Outdated Show resolved Hide resolved
@spasovski spasovski requested a review from mofojed December 13, 2021 19:54
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some memoization for frozen columns at least or we'll be causing more rendering

packages/iris-grid/src/IrisGridTableModel.js Outdated Show resolved Hide resolved
packages/iris-grid/src/IrisGridTableModel.js Outdated Show resolved Hide resolved
packages/iris-grid/src/IrisGridTableModel.js Outdated Show resolved Hide resolved
@spasovski spasovski requested a review from mofojed December 17, 2021 18:52
packages/iris-grid/src/IrisGridTableModel.js Outdated Show resolved Hide resolved
packages/iris-grid/src/IrisGridTableModel.js Outdated Show resolved Hide resolved
packages/iris-grid/src/IrisGridTableModel.js Outdated Show resolved Hide resolved
packages/iris-grid/src/IrisGrid.jsx Show resolved Hide resolved
@spasovski spasovski requested a review from mofojed December 17, 2021 20:03
mofojed
mofojed previously approved these changes Dec 17, 2021
@spasovski spasovski merged commit a76b9b9 into deephaven:main Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants