feat: Removed esbuild runtime dependency #2327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofojed
reviewed
Jan 3, 2025
| needsTranspile ? sourceDir : targetDir, | ||
| serverPaths | ||
| ); | ||
| const downloadPaths = getDownloadPaths(serverStorageDir, serverPaths); |
There was a problem hiding this comment.
Should mention this change in the PR description as well - it's now downloading to the serverStorageDir instead of a target subdirectory.
mofojed
approved these changes
Jan 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DH-18191: Removed esbuild runtime dependency and replaced it with an optional
PostDownloadTransformfunction. Files now get downloaded directly to theserverStorageDirinstead oftargetsubdirectory.BREAKING CHANGES: @deephaven/jsapi-nodejs
loadModulesarguments has changed. Transformation of module types is now the responsibility of the consumer.