fix: allow logout on open file

[wusteven815]

• Fixes Open file blocks logout #1685
  • Moved storeCookieToken from AuthPluginPsk.tsx to AuthPlugin.ts, so it can be exported
  • Logout button now uses that to remove the cookies

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (45fa929) 46.04% compared to head (122ef83) 46.03%.

Files	Patch %	Lines
packages/app-utils/src/components/AppBootstrap.tsx	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1744      +/-   ##
==========================================
- Coverage   46.04%   46.03%   -0.01%     
==========================================
  Files         621      621              
  Lines       37454    37457       +3     
  Branches     9413     9413              
==========================================
+ Hits        17244    17245       +1     
- Misses      20156    20158       +2     
  Partials       54       54              

Flag	Coverage Δ
unit	46.03% <80.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mattrunyon]

I think this only needs to be 1 line in AuthPluginPsk in onLogout add storeRefreshToken(null).

Since we use plugins for auth, any clearing of stored data on logout should be handled by the plugin. We emit an event on a BroadcastChannel on logout so that any 3rd party plugin can respond to a logout request

With any of the plugin architecture, the mindset we use typically is "could I achieve this if I were a 3rd party writing this plugin". What that means is basically no app specific code (anything in app-utils or code-studio) to handle these things as a 3rd party writing a plugin cannot modify any code except their own plugin code. If it can't be achieved, then that's a shortcoming of the APIs we have for plugins

As an example, here's a plugin for KeyCloak which handles many different types of authentication https://github.com/deephaven/deephaven-plugins/blob/main/plugins/auth-keycloak/src/js/src/AuthPluginKeycloak.tsx#L67

[wusteven815]

I think this only needs to be 1 line in AuthPluginPsk in onLogout add storeRefreshToken(null).

When I was debugging this, I noticed that of the 3 listeners (AppBootstrap, AuthPluginPsk, RefreshTokenBootstrap), only AppBootstrap's onLogout was being run, and that was why I added those lines to it. Is the real issue that the other listeners are not running, instead of AppBootstrap not running the logout functions?

[mattrunyon]

If they aren't being run, then that's the real issue. I added a line to the refresh token onLogout and it seemed to run when I logged out for me