Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Floating Cell when editing in Iris Grid #2153

Closed
AkshatJawne opened this issue Jul 17, 2024 · 1 comment
Closed

Floating Cell when editing in Iris Grid #2153

AkshatJawne opened this issue Jul 17, 2024 · 1 comment
Labels
enhancement New feature or request
Milestone
Backlog

Comments

@AkshatJawne
Copy link
Contributor

Similar to applications like Google Sheets, I would propose the addition of a floating or sticky cell editing feature. This feature would allow the cell being edited to remain visible and accessible to the user, even as they scroll through the grid.

Important Notes:

  • Unlike Google Sheets, we would want to display the cell coordinates next to the floating input (may have to modify styling since it could get cluttered with a long column names)
  • We do not want to display the row headers by default

Reference Image:
image
@AkshatJawne AkshatJawne added enhancement New feature or request triage Issue requires triage labels Jul 17, 2024
@AkshatJawne AkshatJawne mentioned this issue Jul 17, 2024
Merged
AkshatJawne added a commit that referenced this issue Jul 17, 2024
@AkshatJawne
fix: error when edited cell is out of grid viewport (#2148)
3fccd43 
Resolves #2087 

**Steps Moving Forward:**
- Clarify whether we want to be able to **handle edits that are not in
the current viewport** -- with my understanding, this will mean we will
have to load in more grid data, which does not seem overly valuable (in
terms of the efficiency tradeoff) since we are dealing with an
improbable edge case where the user begins to edit in the viewport,
continues editing outside of the viewport where the cell originally was,
and then wants to commit those changes outside as well

** A better solution for the edge case above IMO is to **create a new
enhancement ticket** where we attempt to have the editing cell be
floating/sticky in the grid viewport, similar to how it is done on
Google Sheets **

**_Ticket Created:_**
#2153

<img width="276" alt="Screenshot 2024-07-16 at 10 37 02 AM"
src="https://github.com/user-attachments/assets/a5dd6e6e-5f91-4625-b225-ddfc46d5ea89">
mofojed pushed a commit that referenced this issue Jul 23, 2024
@AkshatJawne @mofojed
fix: error when edited cell is out of grid viewport (#2148)
e9e49e6 
Resolves #2087 

**Steps Moving Forward:**
- Clarify whether we want to be able to **handle edits that are not in
the current viewport** -- with my understanding, this will mean we will
have to load in more grid data, which does not seem overly valuable (in
terms of the efficiency tradeoff) since we are dealing with an
improbable edge case where the user begins to edit in the viewport,
continues editing outside of the viewport where the cell originally was,
and then wants to commit those changes outside as well

** A better solution for the edge case above IMO is to **create a new
enhancement ticket** where we attempt to have the editing cell be
floating/sticky in the grid viewport, similar to how it is done on
Google Sheets **

**_Ticket Created:_**
#2153

<img width="276" alt="Screenshot 2024-07-16 at 10 37 02 AM"
src="https://github.com/user-attachments/assets/a5dd6e6e-5f91-4625-b225-ddfc46d5ea89">
@vbabich vbabich added this to the Backlog milestone Jul 24, 2024
@vbabich vbabich removed the triage Issue requires triage label Jul 24, 2024
@vbabich
Copy link
Collaborator

vbabich commented Jul 24, 2024 •
edited
Loading

We don't have row indexes, so it doesn't make sense to float since users wouldn't know what row it is. I appreciate the suggestion though.

@vbabich vbabich closed this as not planned Won't fix, can't repro, duplicate, stale Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@vbabich @AkshatJawne