Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useSearchableViewportData - Support searching for non-text column types #2091

Closed
bmingles opened this issue Jun 20, 2024 · 0 comments · Fixed by #2092
Closed

useSearchableViewportData - Support searching for non-text column types #2091

bmingles opened this issue Jun 20, 2024 · 0 comments · Fixed by #2092
Assignees
@bmingles
Labels
enhancement New feature or request
Milestone
June 2024

Comments

@bmingles
Copy link
Contributor

useSearchableViewportData can be used for components that provide search text in order to filter a windowed table viewport. It currently only supports string column types but will need to support boolean, numeric, and date column types in support of UI ComboBox.
@bmingles bmingles added enhancement New feature or request triage Issue requires triage labels Jun 20, 2024
@bmingles bmingles self-assigned this Jun 20, 2024
@bmingles bmingles mentioned this issue Jun 20, 2024
Merged
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 20, 2024
@bmingles
Fixed tests (deephaven#2091)
32aae73
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 20, 2024
@bmingles
makeSearchTextFilter tests (deephaven#2091)
4e0afbb
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 21, 2024
@bmingles
Unit tests (deephaven#2091)
daa1540
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 24, 2024
@bmingles
Fixed a bug (deephaven#2091)
6769152
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 24, 2024
@bmingles
Fixed tests (deephaven#2091)
8fd8ce0
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 24, 2024
@bmingles
makeSearchTextFilter tests (deephaven#2091)
2c816be
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 24, 2024
@bmingles
Unit tests (deephaven#2091)
d81bc8f
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 24, 2024
@bmingles
Fixed a bug (deephaven#2091)
6bc514b
@mofojed mofojed added this to the June 2024 milestone Jun 25, 2024
@mofojed mofojed removed the triage Issue requires triage label Jun 25, 2024
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 25, 2024
@bmingles
Fixed issue with identifying invalid timezone format (deephaven#2091)
5f949ed
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 27, 2024
@bmingles
Removed date handling from makeFilterValue (deephaven#2091)
938fb0d
@mofojed mofojed mentioned this issue Jul 4, 2024
Merged
mofojed pushed a commit to deephaven/deephaven-core that referenced this issue Jul 4, 2024
@github-actions @deephaven-internal
feat(web): Update web version 0.84.0 (#5698)
0b28f11 
Release notes
https://github.com/deephaven/web-client-ui/releases/tag/v0.84.0

### ⚠ BREAKING CHANGES

* - @deephaven/jsapi-components - The contract of
`useSearchableViewportData` to be more consistent with
`useViewportData`. `usePickerWithSelectedValues` now requires
`timeZone`.
- @deephaven/jsapi-utils - `createSearchTextFilter` requires `timeZone`

### Features

* useSearchableViewportData - support non-text filters
([#2092](deephaven/web-client-ui#2092))
([7009e21](deephaven/web-client-ui@7009e21)),
closes [#2102](deephaven/web-client-ui#2102)
[#2091](deephaven/web-client-ui#2091)


### Bug Fixes

* `isElementOfType` Improved type inference
([#2099](deephaven/web-client-ui#2099))
([e13c9d7](deephaven/web-client-ui@e13c9d7)),
closes [#2094](deephaven/web-client-ui#2094)
* Console does not scroll to bottom when code run from notebook
([#2114](deephaven/web-client-ui#2114))
([e75e716](deephaven/web-client-ui@e75e716))
* make textValue default to key for Normalized Item
([#2113](deephaven/web-client-ui#2113))
([bd3e944](deephaven/web-client-ui@bd3e944))
* Update IrisGridContextMenuHandler getHeaderActions return type to be
more permissive
([#2117](deephaven/web-client-ui#2117))
([4e08b79](deephaven/web-client-ui@4e08b79))

Co-authored-by: deephaven-internal <[email protected]>
@mofojed mofojed mentioned this issue Jul 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
enhancement New feature or request
Projects
None yet
Milestone
June 2024
Development

Successfully merging a pull request may close this issue.

feat: useSearchableViewportData - support non-text filters bmingles/web-client-ui
2 participants
@bmingles @mofojed