docs: ui.switch #793
Merged
docs: ui.switch #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmmcken
requested changes
Sep 3, 2024
| @@ -8,6 +8,7 @@ Sliders allow users to quickly select a value within a fixed range and should be | |||
| ```python | |||
| from deephaven import ui | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
why is this change in this review?
There was a problem hiding this comment.
Just noticed that there was an empty line missing, so thought I could add it here, since it isn't that major of a change.
dsmmcken
requested changes
Sep 5, 2024
Co-authored-by: Don <[email protected]>
Co-authored-by: Don <[email protected]>
Co-authored-by: Don <[email protected]>
dsmmcken
previously approved these changes
Sep 9, 2024
|
Still needs @margaretkennedy review though |
Typo; punctuation
margaretkennedy
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #771