docs: Add the ui.dashboard spec #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mofojed
commented
Nov 8, 2023
mofojed
commented
- Also added ui.row, ui.column, ui.stack
- Also added ui.row, ui.column, ui.stack
dsmmcken
reviewed
Nov 9, 2023
| | Parameter | Type | Description | | ||
| | ----------- | --------- | ------------------------------------------------------------------------------------------------------------------------------------- | | ||
| | `*children` | `Element` | The components to render within the row. | | ||
| | `height` | `int` | The height of the row, relative to the other children of its parent in percent. If not provided, the row will be sized automatically. | |
There was a problem hiding this comment.
is this relative or is it out of 100%?
Like I can't put 200 in there can I ? I guess we could normalize first if GL expects 0-100?
There was a problem hiding this comment.
Yea it's a percent, but there are rules of the total is bigger or less than 100 as well:
https://github.com/deephaven/web-client-ui/blob/561ff22714a8b39cc55b41549712b5ef23bd39cf/packages/golden-layout/src/items/RowOrColumn.ts#L296
Not sure how to concisely explain this.
dsmmcken
reviewed
Nov 13, 2023
Co-authored-by: Don <[email protected]>
- Addressed review comments
dsmmcken
reviewed
Nov 16, 2023
dsmmcken
reviewed
Nov 16, 2023
dsmmcken
reviewed
Nov 16, 2023
dsmmcken
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.