docs: Pure Components #1064
Merged
docs: Pure Components #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofojed
requested changes
Dec 16, 2024
| def event_handler_example(): | ||
| # An event handler for a button | ||
| def button_handler(): | ||
| print("button pressed") |
There was a problem hiding this comment.
In the opening paragraph of this section, you say "update the screen, start an animation, or change data", then in this example you're just printing a log message. I think it would be more powerful to match the two; either include "print a message" in the opening paragraph, or change this example to update some data.
Co-authored-by: Mike Bender <[email protected]>
Co-authored-by: margaretkennedy <[email protected]>
mofojed
approved these changes
Dec 18, 2024
margaretkennedy
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://deephaven.atlassian.net/browse/DOC-237