Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ui.logic button #1050

Merged
merged 9 commits into from
Dec 18, 2024
Merged

feat: ui.logic button #1050

merged 9 commits into from
Dec 18, 2024

Conversation

ethanalvizo
Copy link
Contributor

@ethanalvizo ethanalvizo commented Dec 2, 2024 •
edited
Loading

Closes #941

@ethanalvizo ethanalvizo self-assigned this Dec 2, 2024
@ethanalvizo ethanalvizo marked this pull request as ready for review December 9, 2024 08:30
@ethanalvizo ethanalvizo requested a review from mofojed December 9, 2024 08:30
mofojed
mofojed requested changes Dec 11, 2024
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just enable that last example and should be good to go.

plugins/ui/docs/components/logic_button.md Outdated Show resolved Hide resolved
@ethanalvizo ethanalvizo requested a review from mofojed December 16, 2024 14:08
mofojed
mofojed previously approved these changes Dec 17, 2024
View reviewed changes
@ethanalvizo ethanalvizo requested a review from mofojed December 18, 2024 22:01
@ethanalvizo ethanalvizo enabled auto-merge (squash) December 18, 2024 22:02
@ethanalvizo ethanalvizo merged commit 7c83ec2 into deephaven:main Dec 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@margaretkennedy margaretkennedy margaretkennedy left review comments

@mofojed mofojed mofojed approved these changes

Assignees

@ethanalvizo ethanalvizo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui.logic_button
3 participants
@ethanalvizo @mofojed @margaretkennedy