Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove startup when using embedded server #759

Closed
jnumainville opened this issue Aug 20, 2024 · 0 comments · Fixed by #768
Closed

Remove startup when using embedded server #759

jnumainville opened this issue Aug 20, 2024 · 0 comments · Fixed by #768
Assignees
@jnumainville
Labels
enhancement New feature or request
Milestone
August 2024

Comments

@jnumainville
Copy link
Collaborator

The server doesn't actually need to be started, we just need an instance for tests and building so the imports are resolved, so cleanup plotly-express, template and for the sphinx conf.py as was done in #734
@jnumainville jnumainville added enhancement New feature or request triage labels Aug 20, 2024
@jnumainville jnumainville mentioned this issue Aug 22, 2024
Merged
@vbabich vbabich added this to the August 2024 milestone Aug 27, 2024
@vbabich vbabich removed the triage label Aug 27, 2024
jnumainville added a commit that referenced this issue Aug 29, 2024
@jnumainville
fix: Remove server startup from python tests (#768)
c6c2dd2 
Fixes #759 

Startup is not needed, only an instance, so removed the startup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnumainville jnumainville

Labels
enhancement New feature or request
Projects
None yet
Milestone
August 2024
Development

Successfully merging a pull request may close this issue.

fix: Remove server startup from python tests jnumainville/deephaven-plugins
2 participants
@vbabich @jnumainville